octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #60696] octave --interactive should not imply


From: Rik
Subject: [Octave-bug-tracker] [bug #60696] octave --interactive should not imply --no-line-editing when running in a terminal
Date: Wed, 2 Jun 2021 18:52:52 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36

Follow-up Comment #2, bug #60696 (project octave):

The code for this is in libinterp/corefcn/interpreter.cc.  Decision point is


        line_editing = options.line_editing ();
        if ((! m_interactive || options.forced_interactive ())
            && ! options.forced_line_editing ())
          line_editing = false;


Taking out "|| options.forced_interactive ()" is enough to make the logic work
the way we want.  The new line would be


        if (! m_interactive && ! options.forced_line_editing ())


Is there anything wrong with making this change?  If we are not operating from
a terminal and someone forces interactive do we just say it's their own fault
if things don't work out?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60696>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]