[Octave-bug-tracker] [bug #61826] [octave forge] (fl-core) : should provide an up-to-date tarball/release

[Pantxo Diribarne]

Update of bug #61826 (project octave):

                 Summary: fl-core should provide an up-to-date tarball/release
=> [octave forge] (fl-core) :  should provide an up-to-date tarball/release

    _______________________________________________________

Follow-up Comment #1:

Out of curiosity, I cloned fl-core repository and tried to build it against
the current Octave 6 API: 


$ hg clone http://hg.code.sf.net/p/octave/fl-core octave-fl-core
$ cd octave-fl-core/src
$ make


but that fails.

>> Just releasing the current state should not be too much work. 
As you noted, the package is unmaintained: are you proposing yourself to do
that work? 
If so, or if it may help anyone, here are the changes I had to make to have
the package just compile (completely untested):


diff -r 8e7292478faf src/fl_compose.cc
--- a/src/fl_compose.cc Wed Jul 06 11:09:56 2016 -0400
+++ b/src/fl_compose.cc Fri Jan 14 21:31:50 2022 +0100
@@ -185,7 +185,7 @@
 
        
        // Check if the matrices are both both sparse and set the output
matrix to sparse type
-       if(args(0).is_sparse_type() && args(1).is_sparse_type())              
 
+       if(args(0).issparse() && args(1).issparse())            
                sparse_res = 1;
 
 
@@ -627,11 +627,15 @@
        octave_value_list testArgs;
        testArgs(0) = 1;
        testArgs(1) = 2;
-       feval(func,testArgs);
-       if(error_state)
-               return 0;
-       else
-               return 1;
+    try
+      {
+        octave::feval(func,testArgs);
+      }
+    catch (octave::execution_exception&)
+      {
+        return 0;
+      }
+    return 1;
 }
 
 
@@ -730,7 +734,7 @@
        octave_value_list fargs;                        
        fargs(0) = octave_value(first);
        fargs(1) = octave_value(second);
-       return feval(tnorm,fargs)(0).float_value();
+       return octave::feval(tnorm,fargs)(0).float_value();
 }
 
 
@@ -741,7 +745,7 @@
        octave_value_list fargs;                        
        fargs(0) = octave_value(first);
        fargs(1) = octave_value(second);
-       return feval(snorm,fargs)(0).float_value();
+       return octave::feval(snorm,fargs)(0).float_value();
 }


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61826>

_______________________________________________
  Message posté via Savannah
  https://savannah.gnu.org/