[Octave-bug-tracker] [bug #59149] [octave forge] (signal) Resampling from 22050 to 48000 Hz introduces strange and unexpected artifacts

[Markus Mützel]

Follow-up Comment #52, bug #59149 (project octave):

OT: @Philip: You are browsing the tip of the repository with that link. The
web interface displays the commit message of the tip in that case. That is not
(necessarily) the commit message that was used when that file was added or
last changed. (Maybe that is why you are referring to the interval package?)
The patch at the revision where it was added:
https://hg.octave.org/mxe-octave/file/b507e4ab93d5/src/of-signal-2-error_state.patch

More on topic: I'm not sure if this is the same type of error we've seen in
different parts of Octave before. If it is, we solved it by replacing the
integer literal with a variable. E.g.:

          octave_idx_type zero = 0;
          for (octave_idx_type k = std::max (zero, n-rx+1); k <= n && k*p + lm
< Lh; k++)


Alternatively, you could try using the trinary operator `?`, e.g.:

          for (octave_idx_type k = (n-rx+1 < 0 ? 0 : n-rx+1); k <= n && k*p +
lm < Lh; k++)



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59149>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/