[Octave-bug-tracker] [bug #62277] QR needs to accept "econ" argument for Matlab compatibility

[Rik]

Update of bug #62277 (project octave):

                  Status:         Patch Submitted => Patch Reviewed         

    _______________________________________________________

Follow-up Comment #8:

I reviewed both the functional patch and the documentation change and it looks
good to me.  Marking as "Patch Reviewed".

One thing I would change is to remove the @qcode macro from the word
"economy".  The @qcode macro is to be used for actual code that a user would
type.  But it is impossible to call


qr (..., "economy")


The @qcode is used several times incorrectly around the word "economy".

This has nothing to do with the current patch, but I found it while reviewing.
 The following code with an error produces a message which would be easier to
understand if the malformed argument was in quotes.


qr (magic(3), 'econonomy')
error: qr: type for P must be 'matrix' or 'vector', not econonomy


I think this would be easier if the message said


error: qr: type for P must be 'matrix' or 'vector', not "econonomy"


It should be simple to change the error message format string to add quotes
around the bad argument.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/