[Octave-bug-tracker] [bug #63162] Inaccurate "Events" location in ode45, ode23(s)

[John W. Eaton]

Follow-up Comment #24, bug #63162 (project octave):

I backed out changeset 88fff8521d7.

I asked for the changes to be made separately, not just for the purpose of
reviewing them here, but also because it makes sense to me to have changes
with smaller scope for people who look at the history later.

In rkinterp_bug63163_20221006.patch, I see that the DT argument to
runge_kutta_interpolate is never used.  I also see that if we know that k_vals
never empty, then we don't need to call FCN, so it and ARGS become unused
arguments as well.  Is it guaranteed that k_vals will never be empty because
it is obtained by calling STEPPER in integrate_adaptive prior to calling
runge_kutta_interpolate?  And STEPPER has has already evaluated the
user-supplied function so there should be no need for runge_kutta_interpolate
to also call it?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63162>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/