[Octave-bug-tracker] [bug #63697] canvas not properly redrawn on resize in recent dev

[Dmitri A. Sergatskov]

Follow-up Comment #2, bug #63697 (project octave):

Bisection:

Last good revision is hg id 3105755fa5f1 .
hg id d94ceed56929 broke it:


GLCanvas: avoid multiple inheritance from both QWidget and QObject(4 days
ago)
Author  John W. Eaton <jwe@octave.org>
Date    January 20, 2023 8:49 AM (4 days ago)
Repository      https://hg.savannah.gnu.org/hgweb/octave
Branch  default
Revision        d94ceed56929dbb6e4ef1261234fce2fb72957ba
Properties      
Comment
GLCanvas: avoid multiple inheritance from both QWidget and QObject

To avoid having GLCanvas inherit from both QWidget and QObject, create
a separate class, GLWidget, derived from QOpenGLWidget and use that as
a member of GLCanvas instead of a base class.

* Canvas.h (class Canvas): Derive from QWidget instead of QObject.
(Canvas::Canvas): New argument for parent widget.  Pass parent to
QWidget base class constructor.

* GLCanvas.h, GLCanvas.cc (class GLCanvas): Split QOpenGLWidget parts
into separate GLWidget class.  GLCanvas now processes things related
to the interpreter and forwards to GLWidget for rendering.  Use
unwind_action objects to ensure OpenGL context is restored.
(GLCanvas::m_glwidget): New data member for GLWidget.

* libbgui/graphics/module.mk (OCTAVE_GUI_GRAPHICS_MOC): Add
moc-GLCanvas.cc to the list.
Changed files
libgui/graphics/Canvas.h
libgui/graphics/GLCanvas.cc
libgui/graphics/GLCanvas.h
libgui/graphics/module.mk


Dmitri.
-- 



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63697>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/