[Octave-bug-tracker] [bug #63712] address-sanitizer-flags should be in CFLAGS/CXXFLAGS

[Rik]

Follow-up Comment #2, bug #63712 (project octave):

This is guidance from Gentoo
(https://devmanual.gentoo.org/general-concepts/autotools/index.html)


Sometimes, badly behaved Makefile.am files will override user variables such
as CFLAGS. This must not be allowed — see Not Filtering Variables. There are
separate special variables which should be used in these situations — for
setting CFLAGS. for example, a Makefile.am should use AM_CFLAGS so that user
preferences are not ignored.

So, if a Makefile.am contains, say:

CFLAGS="-Wall"
You should sed or patch it to use:

AM_CFLAGS="-Wall"


As a separate issue, I see that configure.ac is changing CFLAGS occasionally
before doing certain compilation tests.  Maybe that should be looked at.

But, I also agree that WARN_XXX is a weird place to put the address-sanitizer
flags.  Attached is a changeset for review which moves these flags into
XTRA_XXXFLAGS.

(file #54282)

    _______________________________________________________

Additional Item Attachment:

File name: xtra_flags.cset                Size:2 KB
    <https://file.savannah.gnu.org/file/xtra_flags.cset?file_id=54282>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63712>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/