[Octave-bug-tracker] [bug #57352] text height for blank line should approximate that of ordinary character

[Pantxo Diribarne]

Follow-up Comment #6, bug #57352 (project octave):

The following change in ft_text_renderer::update_line_bbox implements what I
proposed in comment #1:


diff -r 6bf833d96cbe libinterp/corefcn/ft-text-renderer.cc
--- a/libinterp/corefcn/ft-text-renderer.cc     Sat Feb 11 09:57:47 2023
-0800
+++ b/libinterp/corefcn/ft-text-renderer.cc     Mon Feb 13 20:55:59 2023
+0100
@@ -775,6 +775,11 @@
       // Add one pixel to the bbox height to avoid occasional text clipping.
       // See bug #55328.
       bb(3) = (m_ymax + 1) - m_ymin;
+
+      // Fix a minimum line height of 0.5 fontsize, see bug #57352.
+      if (bb(3) < 0.5 * m_font.get_size ())
+        bb(3) = 0.5 * m_font.get_size ();
+


But it doesn't actually make a visual difference. Changing to 1 fontsize makes
it better but still not enough.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57352>

_______________________________________________
Message posté via Savannah
https://savannah.gnu.org/