[Octave-bug-tracker] [bug #63901] [octave forge] (fem-fenics) In assemble.cc there is an undeclared identifier 'mlock'

[John W. Eaton]

Update of bug #63901 (project octave):

                 Summary: fem-fenics: In assemble.cc there is an undeclared
identifier 'mlock' => [octave forge] (fem-fenics) In assemble.cc there is an
undeclared identifier 'mlock'

    _______________________________________________________

Follow-up Comment #3:

Are you using the package sources from

https://sourceforge.net/p/octave/fem-fenics/ci/default/tree/

?  Is that really the latest version?

The attached diff (relative to the tip of the default branch of that repo)
should help with the changes in the Octave API.  I noticed that some of these
functions were deprecated in Octave 4.4, so it seems that no one has been
maintaining this code recently.  Is that correct?

Also, I still see the following errors with my attempt at building, but those
don't seem to be problems with the Octave API:


make 
CPPFLAGS="-I. -fpermissive -DDOLFIN_VERSION=\"2019.2.0.dev0\" -DHAS_HDF5
-DHAS_SLEPC -DHAS_PETSC -DHAS_UMFPACK -DHAS_CHOLMOD -DHAS_SCOTCH -DHAS_ZLIB
-DHAS_MPI -DDOLFIN_VERSION=2019.2.0.dev0
-I/usr/lib/petscdir/petsc3.18/x86_64-linux-gnu-real/include
-I/usr/lib/slepcdir/slepc3.18/x86_64-linux-gnu-real/include
-I/usr/lib/x86_64-linux-gnu/openmpi/include/openmpi
-I/usr/lib/x86_64-linux-gnu/openmpi/include -I/usr/include/hdf5/openmpi
-I/usr/include/eigen3 -I/usr/lib/python3/dist-packages/ffc/backends/ufc 
-DLATEST_DOLFIN" /bin/mkoctfile -c Mesh.cc -o Mesh.o
Mesh.cc: In constructor ‘mesh::mesh(Array<double>&, Array<long int>&,
Array<long int>&)’:
Mesh.cc:150:19: error: no matching function for call to
‘dolfin::MeshEditor::open(std::__shared_ptr_access<dolfin::Mesh,
__gnu_cxx::_S_atomic, false, false>::element_type&, std::size_t&,
std::size_t&)’
  150 |       editor.open (*msh, D, D);
      |       ~~~~~~~~~~~~^~~~~~~~~~~~
In file included from /usr/include/dolfin/mesh/dolfin_mesh.h:23,
                 from /usr/include/dolfin.h:10,
                 from mesh.h:21,
                 from Mesh.cc:19:
/usr/include/dolfin/mesh/MeshEditor.h:58:10: note: candidate: ‘void
dolfin::MeshEditor::open(dolfin::Mesh&, dolfin::CellType::Type, std::size_t,
std::size_t, std::size_t)’
   58 |     void open(Mesh& mesh, CellType::Type type, std::size_t tdim,
      |          ^~~~
/usr/include/dolfin/mesh/MeshEditor.h:58:10: note:   candidate expects 5
arguments, 3 provided
/usr/include/dolfin/mesh/MeshEditor.h:73:10: note: candidate: ‘void
dolfin::MeshEditor::open(dolfin::Mesh&, std::string, std::size_t, std::size_t,
std::size_t)’
   73 |     void open(Mesh& mesh, std::string type, std::size_t tdim,
      |          ^~~~
/usr/include/dolfin/mesh/MeshEditor.h:73:10: note:   candidate expects 5
arguments, 3 provided
Mesh.cc: In function ‘octave_value
compute_facet_markers(std::shared_ptr<const dolfin::Mesh>, const Array<long
int>&, std::size_t)’:
Mesh.cc:429:38: error: invalid initialization of reference of type ‘const
std::vector<long unsigned int>&’ from expression of type ‘const
std::vector<long int>’
  429 |     _msh->topology ().global_indices (0);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Mesh.cc:431:38: error: invalid initialization of reference of type ‘const
std::vector<long unsigned int>&’ from expression of type ‘const
std::vector<long int>’
  431 |     _msh->topology ().global_indices (D - 1);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
Mesh.cc: In function ‘octave_value
compute_cell_markers(std::shared_ptr<const dolfin::Mesh>, const Array<long
int>&, std::size_t)’:
Mesh.cc:529:38: error: invalid initialization of reference of type ‘const
std::vector<long unsigned int>&’ from expression of type ‘const
std::vector<long int>’
  529 |     _msh->topology ().global_indices (0);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Mesh.cc:531:38: error: invalid initialization of reference of type ‘const
std::vector<long unsigned int>&’ from expression of type ‘const
std::vector<long int>’
  531 |     _msh->topology ().global_indices (D);
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
make: *** [Makefile_common:31: Mesh.o] Error 1



(file #54472)

    _______________________________________________________

Additional Item Attachment:

File name: fem-fenics-diffs.txt           Size:28 KB
    <https://file.savannah.gnu.org/file/fem-fenics-diffs.txt?file_id=54472>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63901>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/