[Octave-bug-tracker] [bug #63937] mpoles uses relative, not absolute, tolerance for zero poles

[Rik]

Update of bug #63937 (project octave):

                  Status:             In Progress => Patch Submitted        
                 Summary: residue() returns incorrect result in case of pole
at zero => mpoles uses relative, not absolute, tolerance for zero poles

    _______________________________________________________

Follow-up Comment #3:

I ended up re-writing most of the function.  Besides the change from relative
to absolute tolerance for zero poles, I also added input validation (it was
possible to enter a negative value for tolerance which would completely mess
things up), BIST tests that verify compatibility with Matlab even for corner
cases, BIST tests for input validation, re-wrote the documentation, changed
variable names for clarity, and fixed incorrect indentation.  I've attached
the new mpoles.m file for testing.

The only function that uses mpoles() in core is residue() and that function
passes all of its BIST tests.  I don't know if any Octave packages use
mpoles() and need to be tested.

(file #54518)

    _______________________________________________________

Additional Item Attachment:

File name: mpoles.m                       Size:4 KB
    <https://file.savannah.gnu.org/file/mpoles.m?file_id=54518>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63937>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/