RE: Re: MSVC compiler support [patch 27]: OCTAVE_HOME
From:
michael . goffioul
Subject:
RE: Re: MSVC compiler support [patch 27]: OCTAVE_HOME
Date:
Wed, 25 Oct 2006 16:34:18 +0200
> How about this version instead? It should avoid the arbitrary limit.I'm assuming that the
> GetModuleFileName will eventually succeed if thebuffer is large enough. Is there any
> other reason that it could fail?
I don't know, but probably not in normal cases. I tested your patch, it contains an error
in the bin_dir string initalization: the char and size argument should be swapped. Otherwise,
it works fine.
> Also, I'm assuming that this code can be used with MinGW,
Yes. But I don't know which path semantic is expected by the MinGW version of
octave (/usr/bin/octave.exe or C:\\Where\\MinGW\\is\\installed\\bin\\octave.exe)
Note also that there's still a mismatch between the path values used in defaults.cc and
the ones presented in octave_config_info(), because the latter does not use
OCTAVE_HOME.