Re: Q: Low hanging fruit?

[David Bateman]

John W. Eaton wrote:
> On 12-Mar-2008, David Bateman wrote:
> 
> | David Bateman wrote:
> | > John W. Eaton wrote:
> | >> On 11-Mar-2008, David Bateman wrote:
> | >>
> | >> | Ok, added that as well, together with some test code for the function.
> | >>
> | >> Please send dlmread/dlmwrite as hg changesets when they are ready.
> | >>   
> | > Will do..
> | > 
> | >> | size_t n = 
> str.find_first_not_of("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ");
> | >>
> | >> Is there a way to write this using isletter?
> | >>   
> | > probably, though I might use Jaroslav's version of the spreadsheet
> | > format parser..
> | > 
> | > regards
> | > David
> | > 
> | > 
> | >> jwe
> | >>
> | >>   
> | > 
> | > 
> | 
> | Here is my changeset that adds these functions to Octave.
> 
> I added them to my archive.
> 
> Thanks,
> 
> jwe
> 

Here is an additional compatibility fix

D.

# HG changeset patch
# User John W. Eaton <address@hidden>
# Date 1205298355 14400
# Branch release-3-0-x
# Node ID ab8c37132c05219ef9bf2495487ee9887cd1f515
# Parent  4ab9e88e53176cb2065ed22c34ad1f9609abaad1
one more xGELSD workspace fix

diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog
--- a/liboctave/ChangeLog
+++ b/liboctave/ChangeLog
@@ -1,3 +1,7 @@ 2008-03-07  John W. Eaton  <address@hidden
+2008-03-12  John W. Eaton  <address@hidden>
+
+       * dMatrix.cc (Matrix::lssolve): One more xGELSD workspace fix.
+
 2008-03-07  John W. Eaton  <address@hidden>
 
        * idx-vector.cc (IDX_VEC_REP::idx_vector_rep (bool),
diff --git a/liboctave/dMatrix.cc b/liboctave/dMatrix.cc
--- a/liboctave/dMatrix.cc
+++ b/liboctave/dMatrix.cc
@@ -2130,9 +2130,9 @@ Matrix::lssolve (const Matrix& b, octave
       double dminmn = static_cast<double> (minmn);
       double dsmlsizp1 = static_cast<double> (smlsiz+1);
 #if defined (HAVE_LOG2)
-      double tmp = log2 (dminmn) / dsmlsizp1;
+      double tmp = log2 (dminmn / dsmlsizp1);
 #else
-      double tmp = log (dminmn) / dsmlsizp1 / log (2.0);
+      double tmp = log (dminmn / dsmlsizp1) / log (2.0);
 #endif
       octave_idx_type nlvl = static_cast<octave_idx_type> (tmp) + 1;
       if (nlvl < 0)