Re: [PATCH] Thread-safe graphics manager

[Maciek Gajewski]

Michael Goffioul wrote:
> That's the point: on one hand, the interpreter is protected if you use
> locking in the DEFUN_DLD functions; on the other hand any code that uses
> octave graphics system is responsible for locking it. Adding some
> additional protection like you did is harmless, but it must be consistent
> [...]
> You've added a lock in a very few get/set handlers, basically only those
> defined in graphics.cc. But most of the get/set handlers are
> auto-generated, and those are not protected. So, I would say either you
> protect them all, or you don't protect any. If you want to protect them
> all, then you might a problem due to the fact that all get/set
> auto-handlers are defined inline in the generated graphics.h and the class
> gh_manager is only defined afterwards.

Yes, you're right. I shall leave locks only in exported functions.

Maciek Gajewski