|
From: | David Bateman |
Subject: | Re: [changeset] : modify tolerance for single precision test in mappers.cc to respect eps(single) |
Date: | Fri, 29 Aug 2008 10:03:54 +0200 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080725) |
Ben Abbott wrote:
On Aug 26, 2008, at 11:29 PM, John W. Eaton wrote:On 26-Aug-2008, Ben Abbott wrote: | Building the default branch on Mac OSX using Apple's vecLib results in | a failure for the single precision mappers.cc tests. | | I've attached a minimal changeset. I applied it. | However, I notice that single | precision tests often make use of "eps" rather than "eps('single')". | Would it be good form to change all single precision tests to refer to | eps('single')? Yes, that would probably be the right thing to do.Using sed, I only found one instance of this ... the one I noticed previously ;-)Changeset is attached. Ben
I tried to get them all when I added the tests for the single precision code.. Missed this one :-)
D. -- David Bateman address@hiddenMotorola Labs - Paris +33 1 69 35 48 04 (Ph) Parc Les Algorithmes, Commune de St Aubin +33 6 72 01 06 33 (Mob) 91193 Gif-Sur-Yvette FRANCE +33 1 69 35 77 01 (Fax) The information contained in this communication has been classified as: [x] General Business Information [ ] Motorola Internal Use Only [ ] Motorola Confidential Proprietary
[Prev in Thread] | Current Thread | [Next in Thread] |