valgrind warnings

[John W. Eaton]

With the current sources, when I execute

  ./run-octave -valgrind

I see the following warnings just before the prompt appears:

  ==14187== Conditional jump or move depends on uninitialised value(s)
  ==14187==    at 0x6428754: convert_index(int, bool&, int&) (idx-vector.cc:184)
  ==14187==    by 0x64287AC: convert_index(double, bool&, int&) 
(idx-vector.cc:195)
  ==14187==    by 0x642CF8A: 
idx_vector::idx_scalar_rep::idx_scalar_rep<double>(double) (idx-vector.cc:219)
  ==14187==    by 0x56A8D21: idx_vector::idx_vector(double) (idx-vector.h:475)
  ==14187==    by 0x56A8D88: octave_scalar::index_vector() const 
(ov-scalar.h:81)
  ==14187==    by 0x5217BBA: octave_value::index_vector() const (ov.h:420)
  ==14187==    by 0x5216375: Cell::index(octave_value_list const&, bool) const 
(Cell.cc:154)
  ==14187==    by 0x56291D6: 
octave_base_matrix<Cell>::do_index_op(octave_value_list const&, bool) 
(ov-cell.cc:67)
  ==14187==    by 0x562985F: octave_cell::subsref(std::string const&, 
std::list<octave_value_list, std::allocator<octave_value_list> > const&, int) 
(ov-cell.cc:122)
  ==14187==    by 0x562B8FE: octave_cell::subsref(std::string const&, 
std::list<octave_value_list, std::allocator<octave_value_list> > const&) 
(ov-cell.h:78)
  ==14187==    by 0x56C14D7: octave_value::subsref(std::string const&, 
std::list<octave_value_list, std::allocator<octave_value_list> > const&, int) 
(ov.cc:1175)
  ==14187==    by 0x575D257: tree_index_expression::rvalue(int) (pt-idx.cc:398)
  ==14187== 
  ==14187== Conditional jump or move depends on uninitialised value(s)
  ==14187==    at 0x56635D7: make_fcn_handle(std::string const&, bool) 
(ov-fcn-handle.cc:1485)
  ==14187==    by 0x5759605: tree_fcn_handle::rvalue1(int) (pt-fcn-handle.cc:55)
  ==14187==    by 0x574892B: 
tree_argument_list::convert_to_const_vector(octave_value const*) 
(pt-arg-list.cc:195)
  ==14187==    by 0x575C8FB: tree_index_expression::rvalue(int) (pt-idx.cc:300)
  ==14187==    by 0x575B009: tree_index_expression::rvalue1(int) (pt-idx.cc:409)
  ==14187==    by 0x574892B: 
tree_argument_list::convert_to_const_vector(octave_value const*) 
(pt-arg-list.cc:195)
  ==14187==    by 0x575B218: make_value_list(tree_argument_list*, string_vector 
const&, octave_value const*) (pt-idx.cc:180)
  ==14187==    by 0x575B7E2: tree_index_expression::lvalue() (pt-idx.cc:463)
  ==14187==    by 0x574BCE8: tree_simple_assignment::rvalue1(int) 
(pt-assign.cc:230)
  ==14187==    by 0x5755F8C: tree_evaluator::visit_statement(tree_statement&) 
(pt-eval.cc:689)
  ==14187==    by 0x57728CB: tree_statement::accept(tree_walker&) 
(pt-stmt.cc:152)
  ==14187==    by 0x5755D93: 
tree_evaluator::visit_statement_list(tree_statement_list&) (pt-eval.cc:725)

I checked in the following change to avoid these warnings.

  http://hg.savannah.gnu.org/hgweb/octave/rev/b51848e95e4b

I don't know whether my small changes have really fixed the problems
or not, but now all the tests are also passing for me (except the one
data.cc failure we have discussed before, but I'm expecting that
failure because I'm compiling without -O).

jwe