[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Enhnancements to octaveforge/statistics/table
From: |
forkandwait |
Subject: |
Re: Enhnancements to octaveforge/statistics/table |
Date: |
Sat, 6 Feb 2010 18:59:23 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
> > I am interested in patching the table function to use optional vectors of
> > weights, and would like to share that patch.
>
> Great! New patches and ideas are always welcome. Have you already cooked
> up the patch? If so, it makes discussion easier if you post it here, so
> that people have a better understanding of exactly what you want to do.
No, not yet. I will post the patch as soon as I have it written. ;)
> > Should I add a few unit tests somewhere?
>
> That's always a good thing, so yes
Is there an official place they should go so they get run automatically?
> > 3. The patch: I think I can just patch the .m file. Where do I send the
> > patch? Prefered formats (I promise to look that up, but a link would be
> > appreciated).
>
> You should send a Mercurial changeset. That makes your patch easier to
> commit if such an action is agreed upon.
Yay... another VC system to learn... I will start with plain old diff, but work
up to HG as things progress ;)