[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Compile warnings in ARPACK code
From: |
John W. Eaton |
Subject: |
Compile warnings in ARPACK code |
Date: |
Mon, 31 Jan 2011 16:44:28 -0500 |
On 31-Jan-2011, Rik wrote:
| When I try the latest tarball I get these two warnings:
|
| ../../octave-3.3.91/libcruft/arpack/src/dseupd.f:566.72:
|
| if (ncv .eq. 1) go to 30
| 1
| ../../octave-3.3.91/libcruft/arpack/src/dseupd.f:612.72:
|
| 30 end if
| 2
| Warning: Deleted feature: GOTO at (1) jumps to END of construct at (2)
|
| AND
|
| ../../octave-3.3.91/libcruft/arpack/src/sseupd.f:566.72:
|
| if (ncv .eq. 1) go to 30
| 1
| ../../octave-3.3.91/libcruft/arpack/src/sseupd.f:612.72:
|
| 30 end if
| 2
| Warning: Deleted feature: GOTO at (1) jumps to END of construct at (2)
|
| This appears to be because label 30 is an "end if" statement rather than
| lying completely outside the block we are trying to short-circuit with the
| goto. I prepared a patch that moves the label to the next true Fortran
| statement below the 'end if' and it compiles cleanly and passes all tests.
| On the other hand, I don't code Fortran and maybe jumping to an 'end if'
| is supposed to re-evaluate the conditional in the style of a continue
| statement. In that case, the label should be moved backward.
I checked in the changeset. I would probably not jump to an IF
statement. Instead, I was going to add a continue statement to use
for the label. But then I noticed that there are already other
instances of jumping to an IF, so I left it alone.
Thanks,
jwe