Re: octave-glpk MIPGAP

[Jordi Gutiérrez Hermoso]

2011/4/2 Tommaso Balercia <address@hidden>:

> please find the patch for using advanced GPLK features from Octave
> that I posted in the month of March in the mailing list.

This is a bit more than a patch. It's a considerable rewrite of the
GLPK code. I am certainly not able to evaluate it myself for
correctness. I can only comment on superficial things. However, I
wouldn't want to dismiss this effort either.

> For your convenience, I attach the patch here again. I got no
> feedback on it. Perhaps Jordi you would like to have a look at it. A
> more precise description of the enhancements my patch brings can be
> found in my original post, but I'd be glad to summarize them again,
> if needed.

Well, you certainly seem to be speaking as someone who knows what
they're talking about. ;-) I think I will wait for someone who knows
more about the GLPK code, preferrably Nicolò Giorgetti who wrote the
original code. I have CC'ed him here. Nicolò, for your convenience, I
am reattaching Tommaso's patch.

There are a few cosmetic things about your rewrite, like indentation
rules. Please follow GNU style guidelines. Also, your patch seems to
remove a lot of conditional compilation checks based if the system has
GLPK or not. Was that intentional?

Also, it would be nice if you could provide an hg changeset following
the suggestions in my blog post. Please let me know if the
instructions are unclear:

     http://jordi.inversethought.com/blog/how-to-write-a-patch-for-octave/

Thanks,
- Jordi G. H.

glpk.patch
Description: Text Data