Re: Small fix of column number in parser

[John W. Eaton]

On 28-Apr-2011, Jordi Gutiérrez Hermoso wrote:

| On 5 April 2011 04:17, Daniel Kraft <address@hidden> wrote:
| 
| > attached is a hg changeset that fixes wrong column numbers.  If the
| > attached test.m is executed without the patch, one gets:
| >
| > error: bar
| > error: called from:
| > error:   /tmp/test.m at line 2, column -1
| >
| > With the patch, the column number is correctly reported as 1.
| 
| I tested your patch and it worked, so I pushed it to the default
| branch:
| 
|     http://hg.savannah.gnu.org/hgweb/octave/rev/fd367312095a

I don't understand why you removed the line that decremented the
column count when the character is put back on the input stream.
What problem does that fix?  It looks to me like removing that line
would introduce a bug.

| >  In particular, is there some tag I should add to messages sent with
| > patches?  E.g., on the GCC lists, we have "[patch]" in the subjects
| > of messages containing diff's.
| 
| Yes, please use our patch tracker. Easier to have them all in one
| place instead of scattered in our respected inboxen:
| 
|     https://savannah.gnu.org/patch/?group=octave

If the patch fixes a bug, then please attach the patch to a bug report
in the bug tracker.  I'd prefer to just use the patch tracker for new
functions or features, not for bug fixes.

Thanks,

jwe