Re: interpfcn/toplev.cc:1295:24: error: too many decimal points in number

[Ben Abbott]

On Mar 1, 2013, at 6:02 AM, John W. Eaton wrote:

> On 02/28/2013 09:27 PM, Ben Abbott wrote:
>> My build is ending with the error below.  Anyone else seeing this?
>> 
>> Ben
>> 
>> /bin/sh ../libtool  --tag=CXX   --mode=compile /opt/local/bin/g++-mp-4.5 
>> -DHAVE_CONFIG_H -I. -I..  -I../liboctave/cruft/misc -I../liboctave/array 
>> -I../liboctave/numeric -I../liboctave/numeric -I../liboctave/operators 
>> -I../liboctave/operators -I../liboctave/system -I../liboctave/util 
>> -I./octave-value -I./operators -Iparse-tree -I./parse-tree -Iinterp-core 
>> -I./interp-core -Iinterpfcn -I./interpfcn -Icorefcn -I../libgnu -I../libgnu 
>> -D_THREAD_SAFE -I/opt/local/include -I/opt/local/include  -isystem 
>> /opt/local/libexec/llvm-3.1/include -I/opt/local/include/freetype2 
>> -I/opt/local/include   -I/opt/local/include   -Wall -W -Wshadow 
>> -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align 
>> -Wcast-qual -pipe -O0 -g -m64 -ggdb3 -gstabs -D_THREAD_SAFE -D_THREAD_SAFE 
>> -pthread -MT interpfcn/interpfcn_libinterpfcn_la-toplev.lo -MD -MP -MF 
>> interpfcn/.deps/interpfcn_libinterpfcn_la-toplev.Tpo -c -o 
>> interpfcn/interpfcn_libinterpfcn_la-toplev.lo `test -f 'interpfcn/toplev.cc' 
>> || e
> cho './'`
> interpfcn/toplev.cc
>> libtool: compile:  /opt/local/bin/g++-mp-4.5 -DHAVE_CONFIG_H -I. -I.. 
>> -I../liboctave/cruft/misc -I../liboctave/array -I../liboctave/numeric 
>> -I../liboctave/numeric -I../liboctave/operators -I../liboctave/operators 
>> -I../liboctave/system -I../liboctave/util -I./octave-value -I./operators 
>> -Iparse-tree -I./parse-tree -Iinterp-core -I./interp-core -Iinterpfcn 
>> -I./interpfcn -Icorefcn -I../libgnu -I../libgnu -D_THREAD_SAFE 
>> -I/opt/local/include -I/opt/local/include -isystem 
>> /opt/local/libexec/llvm-3.1/include -I/opt/local/include/freetype2 
>> -I/opt/local/include -I/opt/local/include -Wall -W -Wshadow -Wold-style-cast 
>> -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -pipe -O0 
>> -g -m64 -ggdb3 -gstabs -D_THREAD_SAFE -D_THREAD_SAFE -pthread -MT 
>> interpfcn/interpfcn_libinterpfcn_la-toplev.lo -MD -MP -MF 
>> interpfcn/.deps/interpfcn_libinterpfcn_la-toplev.Tpo -c interpfcn/toplev.cc  
>> -fno-common -DPIC -o interpfcn/.libs/interpfcn_libinterpfcn_la-toplev.o
>> interpfcn/toplev.cc:1295:24: error: too many decimal points in number
>> interpfcn/toplev.cc:1295:24: error: too many decimal points in number
>> interpfcn/toplev.cc:1376:29: error: too many decimal points in number
>> interpfcn/toplev.cc:1376:29: error: too many decimal points in number
>> interpfcn/toplev.cc: In function 'octave_value_list 
>> Foctave_config_info(const octave_value_list&, int)':
>> interpfcn/toplev.cc:1295:24: error: expected '}' before 'GNU'
>> interpfcn/toplev.cc:1295:24: error: expected '}' before 'GNU'
>> interpfcn/toplev.cc:1295:24: error: expected ',' or ';' before 'GNU'
>> interpfcn/toplev.cc:1233:8: warning: unused variable 
>> 'octave_supports_dynamic_linking'
>> interpfcn/toplev.cc:1238:15: warning: unused variable 'initialized'
>> interpfcn/toplev.cc:1248:43: warning: unused variable 'conf_info'
>> interpfcn/toplev.cc:1295:41: warning: no return statement in function 
>> returning non-void
>> interpfcn/toplev.cc: At global scope:
>> interpfcn/toplev.cc:1218:1: warning: unused parameter 'args'
>> interpfcn/toplev.cc:1295:42: error: mixing declarations and 
>> function-definitions is forbidden
>> interpfcn/toplev.cc:1296:7: error: expected unqualified-id before '{' token
>> interpfcn/toplev.cc:1296:44: error: expected unqualified-id before ',' token
>> interpfcn/toplev.cc:1297:7: error: expected unqualified-id before '{' token
>> interpfcn/toplev.cc:1297:54: error: expected unqualified-id before ',' token
>> <snip>
> 
> I'm not seeing these problems.  What does the source look like at these lines 
> for you?  What is in the generated oct-conf.h file?  My guess is some system 
> dependent problem with Rik's recent changes to the way oct-conf.h is 
> generated.  Missing quotes?
> 
> jwe

The lines in toplev.cc are all with in octave_config_info.  Line 1295 is below.

1293       { false, "CXX_VERSION", OCTAVE_CONF_CXX_VERSION },
1294       { false, "DEFAULT_PAGER", OCTAVE_DEFAULT_PAGER },
1295       { false, "DEFS", OCTAVE_CONF_DEFS },
1296       { false, "DL_LD", OCTAVE_CONF_DL_LD },
1297       { false, "DL_LDFLAGS", OCTAVE_CONF_DL_LDFLAGS },

The OCTAVE_CONF_DEFS definition in oct-conf.h begins with ...

#define OCTAVE_CONF_DEFS "-DPACKAGE_NAME="GNU Octave"

Which has an nested double-quotes. Other definitions also have the nested 
double-quote.  For example, OCTAVE_CONF_UGLY_DEFS

#define OCTAVE_CONF_UGLY_DEFS "-DPACKAGE_NAME="GNU Octave" <snip>

I presume the interior quotes should be single?  And the OCTAVE_CONF_DEFS 
should begin as?

#define OCTAVE_CONF_DEFS "-DPACKAGE_NAME='GNU Octave'

In any event, I don't see where the problem was introduced, or why this happens 
on MacOS X.

Ben