Re: UGLY_DEFS and command line length

[Rik]

On 03/02/2013 06:33 AM, address@hidden wrote:
> Message: 2
> Date: Sat, 02 Mar 2013 08:23:24 -0500
> From: "John W. Eaton" <address@hidden>
> To: Ben Abbott <address@hidden>
> Cc: Rik Wehbring <address@hidden>,    octave maintainers mailing list
>       <address@hidden>
> Subject: Re: UGLY_DEFS, configure.ac, & toplev.cc on MacOS X
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> On 03/01/2013 07:54 PM, Ben Abbott wrote:
>
>>> >> Adding a single backslash allows me to build.
>>> >>
>>> >> Ben
>>> >>
>>> >> $ hg diff
>>> >> diff --git a/configure.ac b/configure.ac
>>> >> --- a/configure.ac
>>> >> +++ b/configure.ac
>>> >> @@ -2853,7 +2853,7 @@
>>> >>
>>> >> ## We have to insert extra levels of backslash quoting here so that
>>> >> ## the right thing ends up in oct-conf.h.
>>> >> -UGLY_DEFS=`echo $DEFS | $SED 's,\\",\\\\\\\\\\\\\\\\\\",g'`
>>> >> +UGLY_DEFS=`echo $DEFS | $SED 's,\\",\\\\\\\\\\\\\\\\\\\",g'`
>>> >> AC_MSG_NOTICE([defining UGLY_DEFS to be $UGLY_DEFS])
>>> >> AC_SUBST(UGLY_DEFS)
>>> >>
>> >
>> > Rik,
>> >
>> > The attached change allows me to build.
>> >
>> > If it doesn't break your build should this be pushed?
> I checked in two changes to eliminate UGLY_DEFS instead:
>
>    http://hg.savannah.gnu.org/hgweb/octave/rev/2a4f83826024
>    http://hg.savannah.gnu.org/hgweb/octave/rev/cf6788da4152
>
> While making this change, I noticed that UGLY_DEFS appeared three times 
> in the sed commands.  Once in a substitution for OCTAVE_CONF_DEFS and 
> twice for OCTAVE_CONF_UGLY_DEFS.  Without the extra substitutions, a 
> single sed command might not be too long but I left it split in two 
> parts anyway.
>
> jwe
3/2/12

John,

I broke up the sed patterns and put them in a file to work around the line
limitations in the shell rather than in sed.  Doesn't that problem (bug
#38372) still remain?  It seems like "cmd1 | cmd2" must initially be parsed
by a single interpreter which means the overall command line length is
still an issue.  Now that two UGLY_DEFS replacements have been taken out
the line length may be under the original bug reporter's length, but that
should probably be verified.

--Rik