Re: Workspace dialog on MacOS X

[Daniel J Sebald]

On 06/09/2013 11:01 PM, Abbott, Ben wrote:
> On Jun 10, 2013, at 11:16 AM, Daniel J Sebald wrote:
>
> > On 06/09/2013 10:05 PM, Daniel J Sebald wrote:
> >
> > > On 06/09/2013 08:36 PM, Abbott, Ben wrote:
> >
> > > > I assume the spacing between
> > > > columns is coded in c++, and will need to be adjusted there. Iv'e
> > > > attached a diff for what I changed.
> >
> > Oh, I see what you meant, the C++ code routine
> >
> > settings_dialog::read_workspace_colors (QSettings *settings)
> >
> > Yeah, things could be tweaked there by controlling the stretch between columns of the 
> > QGridLayout and so on.  But things look pretty good now.  Why is the right edge being cut 
> > off of your settings dialogs?  In the Workspace image the right color boxes have a 
> > missing edge.  In the Editor Styles image you sent earlier the word "textcolor" 
> > is cut off.
> >
> > Dan
>
>
> I recreated the Workspace tab.  Neither the QTabWidget, QVBoxLayout, or the 
> QGroupBox (workspace_colors_box) extend beyond the window.  However, the red 
> line indicating the right edge of the QVBoxLayout appears to be one pixel to 
> the right of the viewable area.  Can you are Torsten tweak the c++ code to 
> shrink the column width?
>
> Regarding the Editor Styles image, I hadn't noticed the "textcolor" being cut 
> off.  I'll take a look at that.
>
> In any event, a changeset is attached is attached for the workspace tab. Ok to 
> push?

I'll leave it to you and Torsten to tweak the spacing.  I don't think 
you need to be too careful with checking in these changes because they 
are easy to track and fix and they don't shake the tree too much.  Just 
do a visual inspection of the changeset to rule out any odd changes that 
appear from an accidental mouse click or something.  For example, in the 
changeset I see

      <property name="currentIndex">
-      <number>1</number>
+      <number>5</number>
      </property>

I think all that means is that the current selected tab will be 5 
instead of 1 because that is probably where you were working when you 
hit the save button in Qt Designer.  Whether that means the fresh, out 
of the box GUI will start in the 5th tab when selecting Preferences... 
I'm not sure.  Sometimes this Qt Designer could be more explicit about 
what settings are what.

Dan