Re: with hg id c579bd4e12c9 @ -> "src/m-editor/file-editor-tab.cc:1263:55: error: 'valid_identifier' was not declared in this scope"

[John W. Eaton]

On 02/21/2014 11:13 AM, Ben Abbott wrote:
> On Feb 21, 2014, at 10:54 AM, Pantxo Diribarne <address@hidden> wrote:
>
> > 2014-02-21 13:55 GMT+01:00 Ben Abbott <address@hidden>:
> >
> > > On Feb 21, 2014, at 7:01 AM, Pantxo <address@hidden> wrote:
> > >
> > > > Hi,
> > > >
> > > > Same here on mac os 10.9.1 with fink for most dependencies. There may be a
> > > > conflict between "Utils.h" provided by Qt graphics backend and utils.h in
> > > > which "valid_identifier" is defined.
> > > > This doesn't happen for me on linux maybe because it's case sensitive.
> > > >
> > > > Pantxo
> > >
> > > Maybe a naive question, but .... Are you using the same gcc on both Mac and 
> > > Linux?
> > >
> > > I'm running gcc 4.8.
> > >
> > > Ben
> >
> > No, on linux it's gcc-4.7.2 and on mac gcc-4.8.
> > Anyway, I see that there is a bug report with a proposed patch about this issue 
> > :
> >
> > https://savannah.gnu.org/bugs/?41658
> >
> > Pantxo
>
> Perhaps libgui/graphics/Utils.h should be renamed to gui-utils.h?  That looks 
> like a trivial change, but I don't recall the hg magic that makes that a simple 
> task.  What is the command needed to rename a file?

I'm fixing it, but by renaming Utils.h instead of including 
corefcn/utils.h in the libgui/graphics files.

jwe