Re: 'make check' fails

[Rik]

On 07/09/2015 06:50 AM, address@hidden wrote:

Subject:

Re: docs not building

From:

Michael Godfrey <address@hidden>

Date:

07/09/2015 03:04 AM

To:

address@hidden, "John W. Eaton" <address@hidden>

List-Post:

<mailto:address@hidden>

Precedence:

list

MIME-Version:

1.0

References:

<address@hidden> <address@hidden> <address@hidden> <address@hidden> <address@hidden> <address@hidden>

In-Reply-To:

<address@hidden>

Message-ID:

<address@hidden>

Content-Type:

multipart/alternative; boundary="------------070106060003020202070803"

Message:

1

Just a reminder that make check
still fails at least for me. Basically for the same reason  as
doc build failed:

Removing
cd test && . at lines 4648 and 4651 of makefile
fixes it, but you may have a better way.

Yes, I see this too.  This patch seems to work:

diff -r 9e361ecea878 test/module.mk
--- a/test/module.mk    Tue Jul 07 22:00:06 2015 -0400
+++ b/test/module.mk    Thu Jul 09 09:33:30 2015 -0700
@@ -52,7 +52,7 @@ test/.gdbinit: etc/gdbinit
        @$(gdbinit_install_rule)
 
 check-local:
-       cd test && ../run-octave $(RUN_OCTAVE_OPTIONS) --norc --silent --no-history $(srcdir)/test/fntests.m $(srcdir)/test
+       cd test && ../run-octave $(RUN_OCTAVE_OPTIONS) --norc --silent --no-history $(abs_srcdir)/test/fntests.m $(srcdir)/test
 
 if AMCOND_HAVE_LLVM
 check-jit: test/sparse.tst test/bc-overload-tests.stamp test/$(octave_dirstamp)

As jwe mentioned, I think all Makefile rules which use 'cd' need to be checked and possibly updated to use $(abs_srcdir).


--Rik