[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Success of 2015 Code Sprint
From: |
Andreas Weber |
Subject: |
Re: Success of 2015 Code Sprint |
Date: |
Thu, 21 Jan 2016 15:30:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
Am 16.01.2016 um 16:19 schrieb Rik:
> On 12/19/2015 11:06 AM, Andreas Weber wrote:
>> Hi Rik. First thank you for the great preparation (for example the wiki
>> pages). I think we should make a Code Spint more often, 2 or 4 a year.
>> Perhaps we could also make a list with easy clean-up tasks which can be
>> done without a CodeSprint?
>>
>> For example removing the
>>
>> bool success = true;
>> ...
>> {
>> error (..)
>> success = false;
>> }
>> ...
>> return success;
>>
>> constructs.
>>
>> Or is there a reason to keep these?
>
> Andy,
>
> I'm cleaning up my e-mail and came across this unread one from you. Yes,
> this would be a good idea to clean up these easy instances. Most of the
> time I think you can just eliminate the variable declaration and "return
> true" at the end of the function if execution has made it that far. The
> code base has changed a bit so I did a new grep for 'success =' to get a
> list of instances.
As information, done with:
Ă„nderung: 21124:95f8c8cdbffe
Nutzer: Rik <address@hidden>
Datum: Wed Jan 20 21:54:36 2016 -0800
Zusammenfassung: maint: Eliminate 'bool success' variable where possible.
-- Andy