octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Requiring Bourne shell for build


From: Mike Miller
Subject: Re: Requiring Bourne shell for build
Date: Wed, 17 Feb 2016 11:39:14 -0800
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Feb 17, 2016 at 14:16:14 -0500, John W. Eaton wrote:
> What about using something like
> 
>   SHELL=${CONFIG_SHELL-/bin/sh}
> 
> in the bootstrap script (see the attached diff)?  I don't think we need to
> do as much to try to set SHELL (or CONFIG_SHELL) as the autoconf-generated
> configure script does, but this should fix the problem with getting a bad
> value for SHELL from the environment while still allowing users to choose
> what (POSIX) shell to use for running the Octave scripts that are executed
> by the bootstrap script.
> 
> I also see that autoconf sets the variable with '-' and you used ':-'.
> Either is OK with me, but I wonder if there is a reason that autoconf only
> uses the default if CONFIG_SHELL is unset, not also if it is null.
> 
> In any case, if I make this change, then I don't see a problem when doing
> the following with a clean build tree:
> 
>   export SHELL=/bin/tcsh
>   ./bootstrap              ## in source tree
>   /path/to/configure       ## in build tree
>   make

Ok, I think your diff works out to the same effect as this attached one.
Either way works for me if it solves the csh problem.

I think we may still need an export SHELL in the Makefile.

-- 
mike

Attachment: config_shell.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]