Re: OCTAVE_HELP vs HELP_OCTAVE

[John W. Eaton]

On 02/23/2016 04:46 PM, Mike Miller wrote:
> Recent changes have been removing conditionals in the public API and
> changing how they are defined when needed. This is good progress.
>
> We now have a mix of macros of the form HAVE_OCTAVE_X and OCTAVE_HAVE_Y,
> for example
>
>    HAVE_OCTAVE_DEPRECATED_ATTR
>    HAVE_OCTAVE_GUI
>
>    OCTAVE_HAVE_FAST_INT_OPS
>    OCTAVE_HAVE_SIG_JUMP
>
> Can we pick one of these? Personally I would prefer all public symbols
> to start with OCTAVE_.

Yes, symbols that are used in the public header files should be defined 
in octave-config.h and start with the prefix "OCTAVE_".  These should be 
symbols that are either features that have been enabled or 
characteristics of the system that won't change.

But since the symbol in question is OCTAVE_DEPRECATED_ATTR, should we write

  OCTAVE_HAVE_OCTAVE_DEPRECATED_ATTR

?

jwe