Re: Generalised eigenvalue problem

[Barbara Lócsi]

Thanks for the feedback. After your mail I extended my proposal but didn't have enough time to ask for feedback before deadline.

I am also started working on preliminary balancing for eig. And I have some questions about it.

I posted my code here:

EIG.cc

http://pastebin.com/CBBUYYDW

EIG.h

http://pastebin.com/9met8n18

fEIG.cc

http://pastebin.com/9PZLTd48

fEIG.h

http://pastebin.com/Z6RifG2i

eig.cc

http://pastebin.com/RJ6Fi04f

And I also created a diff file (don’t know which one is more useful)

http://pastebin.com/C7PhbzVS

I changed the *geev function calls to the extended versions(*geevx) ( in EIG.cc and fEIG.cc) and implemented checking for 'balance' and 'nobalance' option (in eig.cc).

The *geevx LAPACK functions would allow 2 more options: permute and scale. Should these also be implemented?

I already know that in Matlab there is no option to change balance option in the general case, but the documentation does not mention if the balancing is default or not in the generalised case. How should I handle this?

I think that balancing a Symmetric or a Hermitian matrix does nothing, so I didn't touched those functions (so there is no balancing at all). Please correct me if I am wrong.

I am also not sure what to do in case of an invalid string input. I checked in some other codes and I am still not sure, in balance it does nothing if it got an invalid string as second argument, while in matrix_type it causes:

error: matrix_type: Unknown matrix type ...

So I have 2 ideas:

- error / print usage

- don't care continue with the default setting ('balance')

2016-03-20 16:06 GMT+01:00 Nir Krakauer <address@hidden>:

Please copy the whole maintainers list for Summer of Code related e-mails.

On Sun, Mar 20, 2016 at 6:38 AM, Barbara Lócsi <address@hidden> wrote:

Hi!

I am Barbara Lócsi and I am writing to you because I posted a comment and a patch on a bug that you submitted. I would be happy to receive feedback on it.

https://savannah.gnu.org/bugs/?36437

Thanks, I will let others who know more about how this function works review the patch.

I am also writing to you because I am interested in the 'Generalised eigenvalue problem' project and you are mentioned as a potential mentor. I filled out my public application template, and I would be happy to receive advice and feedback.

http://wiki.octave.org/User:Bumi

Looks like a good start. It would be helpful to add more details on what methods you will use, and check whether there are any existing free-software implementations of some of the methods that you can adapt.

 

I am also noticed that the project description contains all Matlab calling forms of eig that are missing from Octave except one. It does not mention the one that provides ability to choose among the return value format of the eigenvalues (vector or matrix). Is it ok that I included it in my proposal or is there a reason it was left out?

Kind Regards,

Barbara Lócsi

Yes, it's fine to have that also be a part of the proposal.

Nir

This email has been sent from a virus-free computer protected by Avast.
www.avast.com