[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coding style for the interval package
From: |
Joel Dahne |
Subject: |
Re: Coding style for the interval package |
Date: |
Tue, 6 Jun 2017 04:45:48 +0000 |
Hi Oliver,
Okey, then I will adjust the coding style as I go along. As long as
there are only whitespace changes I will try to do it in the same
commit, if there is anything else I notice I will do a separate commit.
Best,
Joel
Oliver Heimlich writes:
> Hi Joel,
>
> you should go with the Octave style, if that is easier for you. As long as
> the style changes only affect white space, you may do these while you edit a
> particular file (just make sure that the file is consistent on save). Diff
> tools can simply ignore whitespace changes.
>
> The reason why the style differs today: I didn't know the wiki page on m-file
> style when I started programming. I looked into the manual, but didn't find
> any hints an m-file style except from the example code. I apparently have set
> my editor with a wrong style.
>
> Oliver
>
>
>
> Ursprüngliche Nachricht
> Von: address@hidden
> Gesendet: 2. Juni 2017 4:20 nachm.
> An: address@hidden; address@hidden
> Cc: address@hidden
> Betreff: Coding style for the interval package
>
> Hi Kai and Oliver,
>
> I have started to modify some of the functions in the interval package
> to support higher dimensions. While doing that I noted that some of the
> coding style decisions for the interval package differs from the Octave
> standard [1]. This includes for example using 4 spaces for indentation
> and not indenting functions. It also keeps trailing white space on empty
> lines.
>
> I'm very reluctant to commit both changes in the coding style and
> implementation changes at the same time so I think the best is to try
> and follow the current coding style for the interval package. This
> however means that I will have to reconfigure my editor, Emacs, to
> comply with this style. Should I try to follow the coding style for new files
> as well? And do you agree with me in not changing the
> coding style at the moment? I will wait with committing anything until I
> have worked this out.
>
> [1] http://wiki.octave.org/Octave_style_guide