Re: warnings shut off in ov.cc?

[John W. Eaton]

On 10/15/19 9:15 PM, Rik wrote:

> It is possible to detect that a warning has been issued and avoid constant
> folding, although the mechanism is clumsy.  This diff does it

Thanks for the patch.  I made a similar change but used an 
unwind_protect object and did the same for array objects.  I checked it 
in here:

  http://hg.savannah.gnu.org/hgweb/octave/rev/c3e24c82157f

> To benchmark things, I created this function
>
> [...]
>
> So a 2% slowdown to add warning detection, but a 15% slowdown if constant
> folding is removed altogether.  Although, let's be real, even if constant
> folding is removed entirely the absolute difference is 2 microseconds which
> isn't very meaningful.

A large array object might show a much larger difference, and I think it 
is worth doing the constant folding if possible.

jwe