[Octave-patch-tracker] [patch #10103] Add weighted standard deviation feature to 'std'

[Nicholas Jankowski]

Update of patch #10103 (project octave):

                 Summary: [octave] (statistics) Weighted standard deviation
for 'std' => Add weighted standard deviation feature to 'std'

    _______________________________________________________

Follow-up Comment #5:

this looks pretty good. passes all tests and applies cleanly.

Are there any other corner cases that should be checked?  (matlab accepts inf
and nan elements for W, is this output compatible?).  Also, i didn't step
through it but looking at line 131, should that be "./" ? is den guaranteed to
be a scalar? 

A couple style points - 

You have a few blank lines with whitespace.  Preferred to trim all trailing
whitespace on lines with and without code. (supposedly that octave editor
feature will be implemented in v7. at the moment I try to remember to edit the
file in notepad++ and use the 'trim trailing whitespace' command.)

the patch should probably add a note to NEWS in the matlab compatibility
section mentioning the extended functionality.

the commit header should be a bit more explicit for patches to core octave,
including the patch or bug number, and a line for each file touched. see
https://wiki.octave.org/Commit_message_guidelines

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10103>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/