[Octave-patch-tracker] [patch #10107] Implement mink and maxk

[Nicholas Jankowski]

Update of patch #10107 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #1:

thanks for the contribution!  this is a great start, but it'll need a few
things to be able to be included in Octave.

looking at the function, I see a few things that would have to be tweaked to
match the octave m-file coding style [1], things like whitespace, etc., and
the help text style [2], which should include each input/output combination
(e.g., idx is an option not required), description of each inputs/outputs,
etc. The copyright notice would need to me modified to match the standard
header (look at a recent m-file, like 'edit cot' as an example).  

in addition, checking on compatibility, looking at the documentation for
mink/maxk[3][4], I see that there are a few other input options not yet
addressed, including 'dim' and 'comparison method'. Partial implementations
are better than nothing, but not sure if you're able to look into adding any
of those. 

Finally, adding the functions is best done by creating a Mercurial patch for
the code, also making changes to NEWS, file lists, author lists, etc. some of
that is detailed at [5]


[1] https://wiki.octave.org/Octave_style_guide
[2] https://wiki.octave.org/Help_text_style_guide
[3] https://www.mathworks.com/help/matlab/ref/mink.html
[4] https://www.mathworks.com/help/matlab/ref/maxk.html
[5] https://wiki.octave.org/Mercurial

Please let us know if any of this is something you'd be interested in
addressing to get your code addition added to the octave code-base. Others
could do this part too, but it might have to wait a little while until someone
has time to work on it.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10107>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/