octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10102] [octave forge] (statistics) Add ne


From: Nicholas Jankowski
Subject: [Octave-patch-tracker] [patch #10102] [octave forge] (statistics) Add new 'missing' functions: missing, ismissing, rmmissing, standardizeMissing, fillmissing
Date: Mon, 2 May 2022 16:55:31 -0400 (EDT)

Follow-up Comment #23, patch #10102 (project octave):

uploading a 99% feature complete fillmissing to capture progress.  it's big.
there's probably a lot of code recduction that could be done if I planned out
function blocks better in advance, but it works. And I apologize for the BIST
count. I added them as I went along for each specific input parameter
variation and kept finding corner cases. 

then I noticed after an upgrade to matlab 2022a while vetting tests for
compatability that behavior had changed. see
https://www.mathworks.com/help/matlab/release-notes.html


ismissing, rmmissing, and groupsummary Functions: Accept data types with no
standard missing value 
The ismissing syntax ismissing(A) now returns logical 0 (false) when the input
data type has no default definition of a standard missing value.

rmmissing and the nummissing and nnz methods of groupsummary no longer error
for input data types with no default definition of a standard missing value.

An example of code that used to error but now executes is:

A = [struct struct struct]; 
TF = ismissing(A)
TF =
    1x3 logical array
    0    0    0


so with that I'll go back and review input behavior for fillmissing, ismissing
and rmmissing to see what's still compatible. then i'll probably work up a
'good enough to close this report' patch.


(file #53168)

    _______________________________________________________

Additional Item Attachment:

File name: fillmissing.m                  Size:94 KB
    <https://file.savannah.gnu.org/file/fillmissing.m?file_id=53168>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10102>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]