Re: [Pan-users] [ANNOUNCE] New Pan release 0.147 (and new maintainer)

[Petr Kovar]

On Sat, 25 Sep 2021 15:16:20 +0200
Rhialto <rhialto-VHf8ExZ4D5A@public.gmane.org> wrote:

> On Thu 23 Sep 2021 at 01:09:43 +0200, Petr Kovar wrote:
> > As a follow up to the announcement below, the Pan 0.147 tarballs have now
> > been uploaded to the usual location at:
> > 
> >   http://pan.rebelbase.com/download/releases/0.147/source/
> 
> That's great!
> 
> I immediately had made a pkgsrc package for the new version, using the
> gitlab.gnome tarball. A few days later, other pkgsrc people noticed that
> the tarballs generated by gitlab are not stable!
> 
> This is the difference between the version I downloaded originally, and
> what it is today:
> 
> $ diff -ur pan-PAN_0_147v1 pan-PAN_0_147v2
> diff -ur pan-PAN_0_147v1/configure.ac pan-PAN_0_147v2/configure.ac
> --- pan-PAN_0_147v1/configure.ac        2021-09-16 18:17:07.000000000 +0200
> +++ pan-PAN_0_147v2/configure.ac        2021-09-16 18:17:07.000000000 +0200
> @@ -8,7 +8,7 @@
>  dnl Get git info for pan-git.version
>  GIT_HASH='afc1447'
>  if test '0' \< $GIT_HASH ; then
> -  GIT_REMOTE=`echo ' (HEAD -> master, tag: PAN_0_147, 
> refs/keep-around/afc1447e125596e4a9ed5ca96b0186ae28ba0bb0)' | awk -F , 
> '{print gensub("[[\(\)]]","","g",$NF)}' 2> /dev/null`
> +  GIT_REMOTE=`echo ' (tag: PAN_0_147, 
> refs/keep-around/afc1447e125596e4a9ed5ca96b0186ae28ba0bb0)' | awk -F , 
> '{print gensub("[[\(\)]]","","g",$NF)}' 2> /dev/null`
>  else
>    dnl git-dir is used for building outside the src tree
>    GIT_HASH=`git --git-dir=$srcdir/.git log -1 --pretty=format:%h 2> 
> /dev/null`
> 
> The original line (when checked out with git) reads
> 
>   GIT_REMOTE=`echo '$Format:%d$' | awk -F , '{print 
> gensub("[[\(\)]]","","g",$NF)}' 2> /dev/null`
> 
> I guess that in the first version, the tag PAN_0_147 was still equal to
> HEAD, but later on, after some commits were made, it wasn't any more.

Following up on this, I'm not really sure why GitLab expands any macros or
runs part of the configure script when generating the archive, which seems
to be the case here from looking at the diff. Ideas welcome.

FWIW, the tarballs uploaded to pan.rebelbase.com are generated by running
the autotools standard make distcheck command. I've it documented here:

https://wiki.gnome.org/Apps/Pan#Making_a_Release

So the contents of the standard tarball and the GitLab one are
different in that make distcheck runs the configure script and expands
GIT_REMOTE and similar to be used in the About dialog, the User-Agent
header etc. to identify the app build. The GitLab archive doesn't run make
distcheck so the build information appears to be way off:

refs/keep-around/afc1447e125596e4a9ed5ca96b0186ae28ba0bb0

Cheers,
pk