[paparazzi-commits] [paparazzi/paparazzi] 16294d: [PPRZ CENTER] Added some more verbose io watch cal...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/paparazzi/paparazzi
  Commit: 16294da4ee5f003efb257bb02bcf1c9a5ae1369b
      
https://github.com/paparazzi/paparazzi/commit/16294da4ee5f003efb257bb02bcf1c9a5ae1369b
  Author: Piotr Esden-Tempski <address@hidden>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M sw/supervision/pc_common.ml

  Log Message:
  -----------
  [PPRZ CENTER] Added some more verbose io watch callbacks.

Trying to investigate the issue of immediately closing processes in
paparazzi center on mac os x Mountain Lion and Mavericks.


  Commit: a9c05c6f1ccad43a8d3df200800d417a1bdb8bc9
      
https://github.com/paparazzi/paparazzi/commit/a9c05c6f1ccad43a8d3df200800d417a1bdb8bc9
  Author: Piotr Esden-Tempski <address@hidden>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M sw/supervision/pc_common.ml

  Log Message:
  -----------
  [PPRZ CENTER] Different approach for io_watch signal handling.

This time we have only one watch reacting to OUT and HUP, wheras it is
ignoring OUT signal and running callback only for HUP.


  Commit: 05e18e04d97babb0068ffe784490e91cf4e7ba41
      
https://github.com/paparazzi/paparazzi/commit/05e18e04d97babb0068ffe784490e91cf4e7ba41
  Author: Piotr Esden-Tempski <address@hidden>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M sw/supervision/pc_common.ml

  Log Message:
  -----------
  [PPRZ CENTER] Capture more of the IO signals.

Trying to gather a bit more data on the signal behavior.


  Commit: e59603f7f9a54ea8a23ed7cc70793c86b3335cdd
      
https://github.com/paparazzi/paparazzi/commit/e59603f7f9a54ea8a23ed7cc70793c86b3335cdd
  Author: Piotr Esden-Tempski <address@hidden>
  Date:   2013-11-16 (Sat, 16 Nov 2013)

  Changed paths:
    M sw/supervision/pc_common.ml

  Log Message:
  -----------
  [PPRZ CENTER] Fixed detection of child processes exitting on Mac OS.

We are now checking if the input channel is empty when receiving the IN
callback. If that is the case we assume that the child process exitted,
ond call the close process callback that normally is treggered by the
HUP callback.

Some background: On OS X glib is using it's own implementation of poll
that does not generate the HUP signal. (It would be possible to add this
functionality modelled after the SSH implementation of bsd_poll) The
glib implementation does generate IN signal when the pipe get's closed.
So we can just check if the input channel is empty and if that is the
case infer that the pipe got closed.


  Commit: b2cff86cd83094e97e0973dfc628d51f527d318c
      
https://github.com/paparazzi/paparazzi/commit/b2cff86cd83094e97e0973dfc628d51f527d318c
  Author: Felix Ruess <address@hidden>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M sw/supervision/pc_common.ml

  Log Message:
  -----------
  Merge pull request #592 from esden/pprz_center_osx_fix

Paparazzi Center on Mac OS X: fixes #290

The missing HUP signal was found in the simulated poll function in glib. The 
glib implementation is copied from glibc which does not implement HUP but only 
generates an IN event instead (Mac OS default behavior would be to generate HUP 
& IN events together). The solution I went for was to just check if the channel 
is empty on IN event, and call the HUP callback.


Compare: 
https://github.com/paparazzi/paparazzi/compare/f6a720f18cbd...b2cff86cd830