[Phpgroupware-developers] Email themes suggestion and patch....

[Mitch \(WebCob\)]

I have reasons... ;-) Hopefully you will agree they are for the greater
good.

The themes thing is interesting, but without using folders for the themes,
they are harder to copy, rename, modify, override, etc. By using
sub-folders, they could in fact be a hotlink to a user's folder, allowing
them to create their own theme without giving them access to muddle up a
copy of shared source.

I ran this little bit of script to alter things for me:

cd email/inc
grep -rl icon_theme *
perl -p -i.ORIGINAL -e "s#\.\\\$icon_theme\.'-#\.\\\$icon_theme\.'/#" \
class.bocompose.inc.php class.boindex.inc.php class.bomessage.inc.php \
class.bopreferences.inc.php class.html_widgets.inc.php
class.svc_nextmatches.inc.php
perl -p -i.ORIGINAL -e
"s#\.\\\$this->icon_theme\.'-#\.\\\$this->icon_theme\.'/#" \
class.bocompose.inc.php class.boindex.inc.php class.bomessage.inc.php \
class.bopreferences.inc.php class.html_widgets.inc.php
class.svc_nextmatches.inc.php

When converted from PERL to English, the above searches and replaces:
.$icon_theme\.'-         => .$icon_theme\.'/
.$this->icon_theme\.'-   => .$this->icon_theme\.'/
effectively changing the system to use subfolders.

cd email/templates/default/images

mkdir evo
mv evo-accounts-16.gif evo/accounts-16.gif
mv evo-accounts-24.gif evo/accounts-24.gif
mv evo-add-attachment-16.gif evo/add-attachment-16.gif
mv evo-add-attachment-24.gif evo/add-attachment-24.gif
mv evo-add-attachment.gif evo/add-attachment.gif
mv evo-address-conduit-16.gif evo/address-conduit-16.gif
mv evo-address-conduit-24.gif evo/address-conduit-24.gif
mv evo-arrow-2left-16.gif evo/arrow-2left-16.gif
mv evo-arrow-2left-24.gif evo/arrow-2left-24.gif
mv evo-arrow-2left-no-16.gif evo/arrow-2left-no-16.gif
mv evo-arrow-2left-no-24.gif evo/arrow-2left-no-24.gif
mv evo-arrow-2right-16.gif evo/arrow-2right-16.gif
mv evo-arrow-2right-24.gif evo/arrow-2right-24.gif
mv evo-arrow-2right-no-16.gif evo/arrow-2right-no-16.gif
mv evo-arrow-2right-no-24.gif evo/arrow-2right-no-24.gif
mv evo-arrow-left-16.gif evo/arrow-left-16.gif
mv evo-arrow-left-24.gif evo/arrow-left-24.gif
mv evo-arrow-left-no-16.gif evo/arrow-left-no-16.gif
mv evo-arrow-left-no-24.gif evo/arrow-left-no-24.gif
mv evo-arrow-right-16.gif evo/arrow-right-16.gif
mv evo-arrow-right-24.gif evo/arrow-right-24.gif
mv evo-arrow-right-no-16.gif evo/arrow-right-no-16.gif
mv evo-arrow-right-no-24.gif evo/arrow-right-no-24.gif
mv evo-compose-message-16.gif evo/compose-message-16.gif
mv evo-compose-message-24.gif evo/compose-message-24.gif
mv evo-customize-16.gif evo/customize-16.gif
mv evo-customize-24.gif evo/customize-24.gif
mv evo-customize3-24.gif evo/customize3-24.gif
mv evo-customize4-24.gif evo/customize4-24.gif
mv evo-delete-message.gif evo/delete-message.gif
mv evo-envelope.gif evo/envelope.gif
mv evo-filters-16.gif evo/filters-16.gif
mv evo-filters-24.gif evo/filters-24.gif
mv evo-filters-config-24.gif evo/filters-config-24.gif
mv evo-folder-16.gif evo/folder-16.gif
mv evo-folder-24.gif evo/folder-24.gif
mv evo-folder-config-16.gif evo/folder-config-16.gif
mv evo-folder-config-24.gif evo/folder-config-24.gif
mv evo-folder-config2-24.gif evo/folder-config2-24.gif
mv evo-forward.gif evo/forward.gif
mv evo-move-message.gif evo/move-message.gif
mv evo-next-message.gif evo/next-message.gif
mv evo-previous-message.gif evo/previous-message.gif
mv evo-reply-all.gif evo/reply-all.gif
mv evo-reply-all2.gif evo/reply-all2.gif
mv evo-reply-to-all.gif evo/reply-to-all.gif
mv evo-reply.gif evo/reply.gif
mv evo-send-16.gif evo/send-16.gif
mv evo-send-24.gif evo/send-24.gif
mv evo-spellcheck-16.gif evo/spellcheck-16.gif
mv evo-spellcheck-24.gif evo/spellcheck-24.gif
mv evo-trash-16.gif evo/trash-16.gif
mv evo-trash-24.gif evo/trash-24.gif
mkdir moz
mv moz-accounts-16.gif moz/accounts-16.gif
mv moz-accounts-24.gif moz/accounts-24.gif
mv moz-add-attachment-16.gif moz/add-attachment-16.gif
mv moz-add-attachment-24.gif moz/add-attachment-24.gif
mv moz-add-attachment.gif moz/add-attachment.gif
mv moz-address-conduit-16.gif moz/address-conduit-16.gif
mv moz-address-conduit-24.gif moz/address-conduit-24.gif
mv moz-arrow-2left-16.gif moz/arrow-2left-16.gif
mv moz-arrow-2left-24.gif moz/arrow-2left-24.gif
mv moz-arrow-2left-no-16.gif moz/arrow-2left-no-16.gif
mv moz-arrow-2left-no-24.gif moz/arrow-2left-no-24.gif
mv moz-arrow-2right-16.gif moz/arrow-2right-16.gif
mv moz-arrow-2right-24.gif moz/arrow-2right-24.gif
mv moz-arrow-2right-no-16.gif moz/arrow-2right-no-16.gif
mv moz-arrow-2right-no-24.gif moz/arrow-2right-no-24.gif
mv moz-arrow-left-16.gif moz/arrow-left-16.gif
mv moz-arrow-left-24.gif moz/arrow-left-24.gif
mv moz-arrow-left-no-16.gif moz/arrow-left-no-16.gif
mv moz-arrow-left-no-24.gif moz/arrow-left-no-24.gif
mv moz-arrow-right-16.gif moz/arrow-right-16.gif
mv moz-arrow-right-24.gif moz/arrow-right-24.gif
mv moz-arrow-right-no-16.gif moz/arrow-right-no-16.gif
mv moz-arrow-right-no-24.gif moz/arrow-right-no-24.gif
mv moz-compose-message-16.gif moz/compose-message-16.gif
mv moz-compose-message-24.gif moz/compose-message-24.gif
mv moz-customize-16.gif moz/customize-16.gif
mv moz-customize-24.gif moz/customize-24.gif
mv moz-customize3-24.gif moz/customize3-24.gif
mv moz-customize4-24.gif moz/customize4-24.gif
mv moz-delete-message.gif moz/delete-message.gif
mv moz-envelope.gif moz/envelope.gif
mv moz-filters-16.gif moz/filters-16.gif
mv moz-filters-24.gif moz/filters-24.gif
mv moz-filters-config-24.gif moz/filters-config-24.gif
mv moz-folder-16.gif moz/folder-16.gif
mv moz-folder-24.gif moz/folder-24.gif
mv moz-folder-config-16.gif moz/folder-config-16.gif
mv moz-folder-config-24.gif moz/folder-config-24.gif
mv moz-folder-config2-24.gif moz/folder-config2-24.gif
mv moz-forward.gif moz/forward.gif
mv moz-move-message.gif moz/move-message.gif
mv moz-next-message.gif moz/next-message.gif
mv moz-previous-message.gif moz/previous-message.gif
mv moz-reply-all.gif moz/reply-all.gif
mv moz-reply-all2.gif moz/reply-all2.gif
mv moz-reply-to-all.gif moz/reply-to-all.gif
mv moz-reply.gif moz/reply.gif
mv moz-send-16.gif moz/send-16.gif
mv moz-send-24.gif moz/send-24.gif
mv moz-spellcheck-16.gif moz/spellcheck-16.gif
mv moz-spellcheck-24.gif moz/spellcheck-24.gif
mv moz-trash-16.gif moz/trash-16.gif
mv moz-trash-24.gif moz/trash-24.gif

Thanks for the effort to all who contribute,

Mitch.