[Phpgroupware-tracker] [bug #4462] Change Password fails for LDAP auth when using SQL accounts

[nobody]

=================== BUG #4462: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4462&group_id=509

Changes by: Hsing-Foo Wang <address@hidden>
Date: Thu 10/23/2003 at 21:44 (GMT)

------------------ Additional Follow-up Comments ----------------------------
Is this still a problem?



=================== BUG #4462: FULL BUG SNAPSHOT ===================


Submitted by: dwdicks                 Project: phpGroupWare                 
Submitted on: Thu 07/24/2003 at 18:40
Category:  API - phpGWapi             Bug Group:  0.9.14.004/5/6 release    
Severity:  5 - Major                  Priority:  High                       
Resolution:  None                     Assigned to:  None                    
Status:  Open                         Component Version:  None              
Platform Version:  None               Reproducibility:  Every Time          

Summary:  Change Password fails for LDAP auth when using SQL accounts

Original Submission:  We using LDAP authentication, but storing our accounts in 
MySQL.  This scenario works fine so far, except for one thing.  When a user 
changes their password, it appears to work, but really fails.

                                                                                

auth_ldap is trying to find the user entry in the director by filtering on 
uidnumber=$_account_id.  This is fine if accounts are in LDAP.  However, if the 
accounts are not in the directory, they will not match.  In this case, we 
should instead filter by looking for a uid that matches the PHPGW user ID.

                                                                                

I've modified class.auth_ldap.inc.php to check and see if the account 
repository is ldap.  If it is, it functions as before.  If it's not, then it 
filters on "uid=".$GLOBALS['phpgw_info']['user']['userid'].



Another option would be to just always filter via uid, even for accounts == 
ldap.

                                                                                

I've attached the modified class.auth_ldap.inc.php as well as the output of cvs 
diff class.auth_ldap.inc.php.

                                                                                

It has been tested with both auth = LDAP and accounts = SQL and auth = LDAP and 
accounts = LDAP

                                                                                

Thanks,

                                                                                

Doug

Follow-up Comments
*******************

-------------------------------------------------------
Date: Thu 10/23/2003 at 21:44       By: pooh_
Is this still a problem?

-------------------------------------------------------
Date: Wed 10/22/2003 at 16:43       By: dwdicks
Note:  The attached patch needs further work.  It appears to break the case 
when you change another user's password from the Admin -> User Accounts menu.


CC list is empty


File Attachments
****************

-------------------------------------------------------
Date: Thu 07/24/2003 at 18:41  Name: class.auth_ldap.inc.php  Size: 5KB   By: 
dwdicks
Fixed class.auth_ldap.inc.php
http://savannah.gnu.org/bugs/download.php?group_id=509&amp;bug_id=4462&amp;bug_file_id=552

-------------------------------------------------------
Date: Thu 07/24/2003 at 18:40  Name: class.auth_ldap.inc.php.diff  Size: 0KB   
By: dwdicks
Diff of class.auth_ldap.inc.php with LDAP Change password bug fix
http://savannah.gnu.org/bugs/download.php?group_id=509&amp;bug_id=4462&amp;bug_file_id=551


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4462&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/