[Phpgroupware-tracker] [bug #14271] Missing define in session class

[Chris Weiss]

Update of bug #14271 (project phpgroupware):

                  Status:                    None => Invalid                
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

is this actualy a problem (other than causing a NOTICE) or just something you
noticed while doing a code review?

First thing, php4 and db are preferences defined in the header manager.  db
was the original way back in php3, with php4 support the php4 sessions
support was added.  The inheritance here is an admin pref, not strange at
all.  DB sessions can still be usefull in a web cluster env if one doens't
want to make a custom php4 session handler (no idea why not though).

Second, all that does is call the the php4 only session_id() function and
store the php4 session id in a set place in the link when the admin doens't
want to use cookies.  If the admin has choosen db sessions, this line of code
does nothing at all because the php4 session id is irrelevant.  I'd agree that
it's a sloppy way to do it, but it's not a bug in .16.

I don't think this is a bug for .16, but a design choice that could have been
implemented a lot better.  If this code remains in the next version it should
be fixed, but realy db sessions in phpgw should be depreciated.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=14271>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/