phpgroupware-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-tracker] [patch #5387] patch for adding support of svn in


From: Dave Hall
Subject: [Phpgroupware-tracker] [patch #5387] patch for adding support of svn in the api and more
Date: Sun, 17 Sep 2006 11:32:10 +1000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060601 BonEcho/2.0b2 (Ubuntu-edgy)

Update of patch #5387 (project phpgroupware):

                  Status:          Ready For Test => In Progress            
             Assigned to:                     ceb => Caeies                 

    _______________________________________________________

Follow-up Comment #1:

This looks good.

A few suggestions

Move the diff CSS to filemanage/templates/base/css/base.css and just use
classes, there is no need to allow it to only be applied to td elements

Fix up the phpdocs for new SVN classes

Split the svn parser off into a new class.  If it is 3rd party code put it
into phpgwapi/inc/svnparser and just include it in the top of the svn_dav
class

Feel free to commit it

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5387>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]