[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Phpgroupware-tracker] [patch #6102] various fixes in {ipc_, so, bo}note
From: |
Dave Hall |
Subject: |
[Phpgroupware-tracker] [patch #6102] various fixes in {ipc_, so, bo}notes |
Date: |
Wed, 18 Jul 2007 11:24:52 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20061201 Firefox/2.0.0.4 (Ubuntu-feisty) |
Update of patch #6102 (project phpgroupware):
Status: None => In Progress
Assigned to: None => johang
Summary: random hacks in {ipc_, so, bo}notes => various
fixes in {ipc_, so, bo}notes
_______________________________________________________
Follow-up Comment #1:
I am feeling lazy tonight. Here are the comments I made on IRC about the
patches.
<skwashd> johang: btw please provide 1 patch when it should all be applied in
1 hit
<johang> oh, I see. makes sense.
<johang> I'll do that next time
<skwashd> np
<skwashd> 6102
<skwashd> bonotes fine
<skwashd> sonotes ... did you check for occurances of $this->db2?
<johang> yepp. was unused.
<skwashd> ok np with that one then
<skwashd> the ipc notes
<skwashd> intval($var) has more overhead than a caste (int) $var
<johang> shoot. thought it was the other way around :)
<skwashd> the rest looks like good optimisations
<skwashd> a function call always has more overhead
<skwashd> you will see a lot of intval()s in our code ... i added them until
someone pointedit out to me
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6102>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/