[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] MI: Make JSON msg field consistent with C counterpart
From: |
Mohammad-Reza Nabipoor |
Subject: |
Re: [PATCH] MI: Make JSON msg field consistent with C counterpart |
Date: |
Thu, 2 Sep 2021 22:54:18 +0430 |
Hi, Jose.
On Wed, Sep 01, 2021 at 03:38:50PM +0200, Jose E. Marchesi wrote:
>
> Hi Mohammad.
>
> > C code uses "kind" to distinguish messages in `poke/pk-mi-msg.h`,
> > but JSON messages use "type". This commit change the name "type"
> > to "kind".
>
> I'm not sure if you already applied this.
No! I'm waiting for the commander to come back and review the patches :)
> ... OK for both master and
> maint/poke-1 (if applicable there).
>
Pushed both to master and maint/poke-1 (with some modifications).
Thanks.