[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Assertion in sort.c

From: John Darrington
Subject: Re: Assertion in sort.c
Date: Sun, 9 Jan 2005 16:54:26 +0800
User-agent: Mutt/1.5.4i

On Sun, Jan 09, 2005 at 12:01:41AM -0800, Ben Pfaff wrote:
     John Darrington <address@hidden> writes:
     > OK.  I've checked in patch which partially fixes the problems.
     Should be fixed now.  Works for me.

Thanks. (I thought merge_once looked suspicious, so I tried fixing it, but
without the casefile fixes, it made things worse. So I concluded that
Ben must have had a good reason for using a negative index into an
array ....)

     I added a test pattern to the casefile tests which detects the
     main problem that had to be fixed.  If you're happy with that,
     you could remove the test, which does take a
     really long time compared to the other tests.

I'd feel happier with an end to end test, but I've checked in a patch
to that big-input-2 which takes the total execution time down (on my
machine) from 20 seconds to 5 seconds.


PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: pgp8rtFVc_Ol0.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]