[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: John Darrington
Subject: sfm-read.c
Date: Tue, 1 Nov 2005 09:12:41 +0800
User-agent: Mutt/1.5.9i

I was rather surprised at this function in sfm-read.c

/* Displays a corrupt sysfile error. */
static void
corrupt_msg (int class, const char *format,...)
  struct error e;
  va_list args;

  e.class = class;
  getl_location (&e.where.filename, &e.where.line_number);
  e.title = _("corrupt system file: ");

  va_start (args, format);
  err_vmsg (&e, format, args);
  va_end (args);

In particular the getl_location call.  System files dont have lines, 
so line numbers don't make much sense.
Shouldn't we just set the where variable to {0,0} in this case??


PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]