[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Directory restructuring

From: Ben Pfaff
Subject: Re: Directory restructuring
Date: Sun, 05 Feb 2006 08:50:53 -0800
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

John Darrington <address@hidden> writes:

> Great! Your patch applied OK.  It initially failed 3 tests because of
> dict_get_filter being passed NULL, but I added a quick check for that
> condition in vfm.c (close_active_file) and it seemed to fix the problem.

I actually thought about this for a minute and realized that
those two lines should just be deleted.  The current structure of
the dictionary means we just don't need it, and in fact it was
probably incorrect:

cd /home/blp/pspp/reorg/src/
diff -up /home/blp/pspp/reorg/src/vfm.c\~ /home/blp/pspp/reorg/src/vfm.c
--- /home/blp/pspp/reorg/src/vfm.c~     2006-02-02 17:56:29.000000000 -0800
+++ /home/blp/pspp/reorg/src/vfm.c      2006-02-05 08:49:04.000000000 -0800
@@ -448,8 +452,6 @@ close_active_file (void)
   cancel_temporary ();
   expr_free (process_if_expr);
   process_if_expr = NULL;
-  if (dict_get_filter (default_dict) != NULL && !FILTER_before_TEMPORARY)
-    dict_set_filter (default_dict, NULL);
   dict_set_case_limit (default_dict, 0);
   dict_clear_vectors (default_dict);
   cancel_transformations ();

Regarding a Microsoft/Xerox agreement:
        "This is a match made in heaven.
         Both companies excel at copying other people's work."
address@hidden <URL:>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]