pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Renaming


From: Ben Pfaff
Subject: Re: Renaming
Date: Thu, 02 Mar 2006 15:26:59 -0800
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

John Darrington <address@hidden> writes:

> On Thu, Mar 02, 2006 at 08:58:08AM -0800, Ben Pfaff wrote:
>      Depending on how you decide to do header file include paths,
>      public.h and private.h in src/expressions should perhaps be
>      renamed.
>
> Certainly if we go down the "lots of -Is" approach; as 
> #include <public.h> isn't very meaningfull.  Perhaps we should decide
> on the inclusion issue now.  At the moment, I think I'm leaning
> towards the explicit #include option --- ie. all dirs are compiled
> with -I src -I lib -iquote ./ --- This will mean that things outside the
> src/language/expressions dir will need to use
> #include <src/language/expressions/public.h> but inside the
> expressions dir one can use #include "private.h"

I'm more familiar with this approach, for what it's worth.
It's okay with me.

>      I assume you'll add some kind of summary of changes to
>      src/ChangeLog before you check in?
>
> Actually I'd put this in ./ChangeLog ; maybe I should move some of the
> comments to src/ChangeLog.  I've also added empty ChangeLog files for
> all the new directories.

OK.
-- 
"Let others praise ancient times; I am glad I was born in these."
--Ovid (43 BC-18 AD)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]