[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new string library

From: John Darrington
Subject: Re: new string library
Date: Sat, 10 Jun 2006 10:24:20 +0800
User-agent: Mutt/1.5.4i

In the GUI code I had been using GString from GLib.  It was very
similar to pspp's old struct string class.  The main difference that I
noticed was that unlike struct string, GString's data member was
always null terminated which made life a lot easier.

I'm a little concerned at the CC_* macros:

1.  There are already similarly named symbols in data/settings.c used
    for things pertaining to Custom Currency; Overloading the CC_
    prefix might cause confusion.

2.  Obvously macros like CC_ALNUM are only correct for the C locale.
    Not a problem so long as everyone's aware of it, but naive
    programmers might make some mistakes ...


On Fri, Jun 09, 2006 at 03:55:30PM -0700, Ben Pfaff wrote:
     I've revised, and largely rewritten, the string library in
     libpspp/str.[ch].  The new version is much more powerful.  It has
     already allowed some code to be significantly simplified and made
     easier to read.  I'm expecting that it should allow similar
     improvements across much of the rest of the code base, especially
     in situations where strings are parsed.
     Function naming has changed quite a bit.  The new names are much
     more uniform than the old ones were, so this should be an
     improvement also.

PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See or any PGP keyserver for public key.

Attachment: pgpZo4ytmtBNV.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]