[patch #5561] Connect debugger on error

[Ben Pfaff]

Update of patch #5561 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           
             Assigned to:                    None => jmd                    

    _______________________________________________________

Follow-up Comment #1:

I am intrigued.  This is interesting.  It is also fairly simple and clean. 
It'd be fine with me if you committed it.

In connect_debugger: perror already adds a colon to the string, so you don't
need one of your own in its argument.  Could you use execlp("gdb", ...) to
find gdb in $PATH, instead of specifying /usr/bin explicitly?

I'd tend to argue that, if fork or exec fails, we should return from
connect_debugger and report the error in the usual manner, so that in
bug_handler the new code would just be #if
DEBUGGING/connect_debugger();/#endif

In debugger.h, the "G" is tripled in DEBUGGGER_H.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?5561>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/