[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5874] Automatically add long name table.

From: Ben Pfaff
Subject: [patch #5874] Automatically add long name table.
Date: Thu, 19 Apr 2007 15:15:01 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Update of patch #5874 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           


Follow-up Comment #1:

Looks good.  A few nits:

It might be slightly clearer to write:
  strcpy (long_name, short_name);
  str_lowercase (long_name);

I wonder whether we should add a dictionary function to set both long and
short names at the same time.  It would avoid the need to duplicate the long
comment, for one.

In the future please consider using "cvs -q diff".  It makes patches slightly
easier to read by dropping all the "? unknown/file/name" lines.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]