[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5907] Implement ADD DOCUMENT command.

From: Ben Pfaff
Subject: [patch #5907] Implement ADD DOCUMENT command.
Date: Wed, 02 May 2007 14:38:23 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Update of patch #5907 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           


Follow-up Comment #1:

Some quibbles:

In the documentation, I don't think that the . should be on a separate line;
although that's valid syntax, it's not a style I've commonly seen.

In cmd_add_documents, please add a period to the end of the error message.

I don't think the "x / 80" => "DIV_RND_UP (x, 80)" changes are correct.  In
each case, if the number of bytes is not a multiple of 80, then rounding up
will cause subsequent code to read beyond the end of the document string.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]