[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5968] initial version of interaction

From: John Darrington
Subject: [patch #5968] initial version of interaction
Date: Mon, 28 May 2007 02:16:46 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20060607 Debian/1.7.12-1.2

Follow-up Comment #3, patch #5968 (project pspp):

There's still one outstanding instance of var_get_type (v[i]) == VAR_STRING,
which might be better written as var_is_alpha(v[i]).

The assignment tmp = 1.0; could now be removed, and tmp initialised to 1.0 as

Looking at this function now, I'm not sure if it'll behave itself if n_vars
is zero.  Perhaps it never will be, in which case an assertion to that effect
wouldn't hurt.

Maybe you want to consider doing these things.  I'm happy for it to be
checked in anyway.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]